Review Request: Make python scriptengine installable if python3 is your main python

Aaron J. Seigo aseigo at kde.org
Wed Nov 9 19:25:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103096/#review8057
-----------------------------------------------------------

Ship it!


this looks like valid python 2 and 3 from what i've seen in the python docu online.. :)

- Aaron J. Seigo


On Nov. 9, 2011, 7:06 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103096/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 7:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Updated the syntax to be liked by both python3 and python2.
> 
> NOTE: I AM A TOTAL PYTHON NOOB THIS NEEDS PROPER REVIEWING
> 
> 
> Diffs
> -----
> 
>   plasma/generic/scriptengines/python/plasmascript.py 34fdfc0 
> 
> Diff: http://git.reviewboard.kde.org/r/103096/diff/diff
> 
> 
> Testing
> -------
> 
> I can now run make install
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/65aab89f/attachment.html>


More information about the Plasma-devel mailing list