Review Request: Make IconTask use Plasma::Theme'd "close" button

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103092/#review8049
-----------------------------------------------------------


other than the small issue with QDir, it looks good to me ... it's Craig's widget though so he has to have the last say to ship it or not.


applets/icontasks/tooltips/windowpreview.cpp
<http://git.reviewboard.kde.org/r/103092/#comment6936>

    you don't need to place a special separator. '/' is enough .. QDir is uneeded here as a result :)


- Aaron J. Seigo


On Nov. 9, 2011, 3:59 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103092/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 3:59 p.m.)
> 
> 
> Review request for Plasma and Craig Drummond.
> 
> 
> Description
> -------
> 
> Simple patch which makes IconTask look more consistent with Plasma Theme.
> It renders the "close" button using Plasma::Theme, and fallback to the standard window-close icon if nothing better is available :)
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/tooltips/windowpreview.cpp 3e0c865 
> 
> Diff: http://git.reviewboard.kde.org/r/103092/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works as expected (see pictures below).
> 
> 
> Screenshots
> -----------
> 
> ToolTip with themed "close" button
>   http://git.reviewboard.kde.org/r/103092/s/329/
> ToolTip with default "close" icon
>   http://git.reviewboard.kde.org/r/103092/s/330/
> ToolTip with themed "closed" button, resized
>   http://git.reviewboard.kde.org/r/103092/s/331/
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/54482446/attachment-0001.html>