<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103092/">http://git.reviewboard.kde.org/r/103092/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">other than the small issue with QDir, it looks good to me ... it's Craig's widget though so he has to have the last say to ship it or not.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103092/diff/2/?file=40720#file40720line63" style="color: black; font-weight: bold; text-decoration: underline;">applets/icontasks/tooltips/windowpreview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">WindowPreview::WindowPreview(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">svgPath</span><span class="p">(</span><span class="s">"widgets"</span> <span class="o">+</span> <span class="n">QDir</span><span class="o">::</span><span class="n">separator</span><span class="p">()</span> <span class="o">+</span> <span class="s">"configuration-icons"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you don't need to place a special separator. '/' is enough .. QDir is uneeded here as a result :)</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 9th, 2011, 3:59 p.m., Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Craig Drummond.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2011, 3:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple patch which makes IconTask look more consistent with Plasma Theme.
It renders the "close" button using Plasma::Theme, and fallback to the standard window-close icon if nothing better is available :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and works as expected (see pictures below).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/tooltips/windowpreview.cpp <span style="color: grey">(3e0c865)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103092/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103092/s/329/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button_1_400x100.png" style="border: 1px black solid;" alt="ToolTip with themed "close" button" /></a>
<a href="http://git.reviewboard.kde.org/r/103092/s/330/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button1_400x100.png" style="border: 1px black solid;" alt="ToolTip with default "close" icon" /></a>
<a href="http://git.reviewboard.kde.org/r/103092/s/331/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button3_400x100.png" style="border: 1px black solid;" alt="ToolTip with themed "closed" button, resized" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>