Review Request: TaskManager: TaskAction changes from IconTasks

[Craig Drummond]

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/taskactions.cpp, line 600
> > <http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line600>
> >
> >     this is a misuse of QAction. you can add QActions to a QAction and that parent QAction becomes the submenu. no need for such custom property setting/reading and menu creation.
> 
> Craig Drummond wrote:
>     This was for dock-manager plugin support - just to make things easier on my side - then there's a 1:1 mapping between the dockmanager item and the QAction. No biggie, I can always remove this.
> 
> Aaron J. Seigo wrote:
>     hm... can't you add all the dockmanager items to a common QAction? should be no harder than calling setProperty on them? or are these properties already set by the dockmanager API? (in which case i'd suggest the dock manager API could use improving :)

Hmm... How do I add a QAction to a QAction? I cant see this anywhere in the documentation. I've tried QActionGroup, creating QActions with the QAction as a parent. All failed :-(


- Craig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103004/#review7794
-----------------------------------------------------------


On Oct. 31, 2011, 8:40 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103004/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> 1. Add NewInstance action to launch a new instance of an application.
> 2. Move toggle launcher action out of advanced menu.
> 3. Don't show application name in 'Show A Launcher' action, as might not know the real name at this time (e.g. no desktop file read).
> 4. Add application actions, to be shown at the top of the right-click menu. IconTasks uses this to show recent docuents, dock manager menu items, and unity items.
> 5. A ToolTipMenu class is created, so that tooltips may be give for menu items. This is so that IconTasks can display the full path of a documents in the recent documents menu.
> 6. Add option to have only basic window controls in menu.
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/taskactions.h 2b5a641 
>   libs/taskmanager/taskactions.cpp 0e6ba8e 
>   libs/taskmanager/taskactions_p.h 913966c 
> 
> Diff: http://git.reviewboard.kde.org/r/103004/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/cc12b38c/attachment.html>