Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

[Craig Drummond]

> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/taskitem.cpp, lines 378-385
> > <http://git.reviewboard.kde.org/r/103005/diff/1/?file=39928#file39928line378>
> >
> >     create KSysGuard::Processes on the stack to prevent the need to delete it later? these kinds of local new's often become memory leaks with time ;)
> >     
> >     (also, watch ws! spaces around '=', trailing ws)

I agree. I thought I tried using it on the stack, and had issues. But I've just tried again and it was fine. odd.


> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/taskitem.cpp, line 416
> > <http://git.reviewboard.kde.org/r/103005/diff/1/?file=39928#file39928line416>
> >
> >     if isStartupItem, d->task should be null as well ...

Sorry, not sure what you are trying to say here...

The "if" is checking , that if we are not a task and not a startup then return an empty url - otherwise attempt to determine the launcherUrl


> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/taskmanagerrulesrc, line 13
> > <http://git.reviewboard.kde.org/r/103005/diff/1/?file=39929#file39929line13>
> >
> >     perhaps an entry for kcmshell4 as well?

Currently kcmshell4 *cannot* be matched to a launcher. I agree this should to be fixed.


- Craig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103005/#review7797
-----------------------------------------------------------


On Oct. 31, 2011, 8:41 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103005/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add more KTrader queries when attempting to match a task to a launcher.
> 
> (Part of IconTasks' taskmanager changes)
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/CMakeLists.txt 57f5f73 
>   libs/taskmanager/startup.h 997eb7e 
>   libs/taskmanager/startup.cpp e4df7c7 
>   libs/taskmanager/task.h 45acd5a 
>   libs/taskmanager/task_win.cpp ea03004 
>   libs/taskmanager/task_x11.cpp 04af0c7 
>   libs/taskmanager/taskitem.h 5de8478 
>   libs/taskmanager/taskitem.cpp 0a768e5 
>   libs/taskmanager/taskmanagerrulesrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103005/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/627b921f/attachment-0001.html>