Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103005/#review7797
-----------------------------------------------------------


looks pretty good; whitespace needs cleaning up throughougt the patch to match the kdelibs style, and a few minor comments ... but once ws is cleaned up, this can go in imo :)


libs/taskmanager/startup.cpp
<http://git.reviewboard.kde.org/r/103005/#comment6705>

    extra ws



libs/taskmanager/task_win.cpp
<http://git.reviewboard.kde.org/r/103005/#comment6706>

    replace the TODO with a FIXME for easier finding :)



libs/taskmanager/taskitem.cpp
<http://git.reviewboard.kde.org/r/103005/#comment6707>

    create KSysGuard::Processes on the stack to prevent the need to delete it later? these kinds of local new's often become memory leaks with time ;)
    
    (also, watch ws! spaces around '=', trailing ws)



libs/taskmanager/taskitem.cpp
<http://git.reviewboard.kde.org/r/103005/#comment6708>

    if isStartupItem, d->task should be null as well ...



libs/taskmanager/taskmanagerrulesrc
<http://git.reviewboard.kde.org/r/103005/#comment6709>

    perhaps an entry for kcmshell4 as well?


- Aaron J. Seigo


On Oct. 31, 2011, 8:41 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103005/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add more KTrader queries when attempting to match a task to a launcher.
> 
> (Part of IconTasks' taskmanager changes)
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/CMakeLists.txt 57f5f73 
>   libs/taskmanager/startup.h 997eb7e 
>   libs/taskmanager/startup.cpp e4df7c7 
>   libs/taskmanager/task.h 45acd5a 
>   libs/taskmanager/task_win.cpp ea03004 
>   libs/taskmanager/task_x11.cpp 04af0c7 
>   libs/taskmanager/taskitem.h 5de8478 
>   libs/taskmanager/taskitem.cpp 0a768e5 
>   libs/taskmanager/taskmanagerrulesrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103005/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/5ffe7e39/attachment.html>