Review Request: The tooltip's tag are mismatch on krandrtray

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101430/#review3500
-----------------------------------------------------------


This review has been submitted with commit 7b7a9512d73312712e99d5fb082dfb4d7575d6e9 by Max Lin.

- Commit


On May 24, 2011, 2:55 p.m., Max Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101430/
> -----------------------------------------------------------
> 
> (Updated May 24, 2011, 2:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> After launch krandrtray, move cursor up on krandrtray, it will shows tooltip, however, looks the tag are not match so caused context are not aligned, and text color are not consistent, we also can catch the "tag mismatch" debug message. I added "<tr>" tag to match with "</tr>" tag, after with this patch, the "tag mismatch" message disappear.
> 
> 
> Diffs
> -----
> 
>   kcontrol/randr/krandrtray.cpp aab7295 
> 
> Diff: http://git.reviewboard.kde.org/r/101430/diff
> 
> 
> Testing
> -------
> 
> Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screenshot before/after with this patch.
> 
> 
> Screenshots
> -----------
> 
> tag mismatch
>   http://git.reviewboard.kde.org/r/101430/s/172/
> tag match
>   http://git.reviewboard.kde.org/r/101430/s/173/
> 
> 
> Thanks,
> 
> Max
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110525/fbb47e9d/attachment.htm