Review Request: Add --replace to plasma-desktop

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101316/#review3219
-----------------------------------------------------------


what i like about it: it would make switching from plasma-desktop to plasma-netbook a bit easier from the kcm that enables that; it would make it more likethe windowmanager and reduce instructions on how to restart plasma-dekstop to one step.

what concerns me is the crashes you note. given that it is the weather engine, my guess is that the global objects are not being cleaned up before the applets. (so the dataengine is being destroyed before the weather applet is gone.) i can't see anything in the patch that should change those semantics though; i assume that PlasmaApp::cleanup() is still getting called before ~PlasmaApp? perhaps you could throw a backtrace somewhere to look at.

my other concern is that this makes plasma-desktop rely on X11. what happens when we move to a different system, e.g. wayland?

- Aaron J.


On May 8, 2011, 7:43 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101316/
> -----------------------------------------------------------
> 
> (Updated May 8, 2011, 7:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Replaces KUniqueApplication by a KApplication and adds a selection owner for Plasma Shells like the selection owner used by KWin (WMs in general). If plasma-desktop is already running, it is possible to restart with "plasma-desktop --replace". If plasma-desktop is running and you don't add the --replace, it will only yell (like KWin). The same could be added to the other shells like netbook, to easily restart/switch during development. I got the idea from this thread on wm-spec mailinglist: http://mail.gnome.org/archives/wm-spec-list/2011-January/msg00002.html
> 
> Current state: it works, plasma-desktop is replaced, but sometimes the WeatherEngine is causing a crash when exiting the previous one. So it is possible that the change from KUniqueApplication to KApplication is opening Pandora's Box. You decide whether it is worth to spend more time on it.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/main.cpp 6f04e98 
>   plasma/desktop/shell/plasmaapp.h 06ee523 
>   plasma/desktop/shell/plasmaapp.cpp 58e8947 
> 
> Diff: http://git.reviewboard.kde.org/r/101316/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110509/17c8aaf4/attachment.htm