Review Request: Add --replace to plasma-desktop

Martin Gräßlin kde at martin-graesslin.com
Sun May 8 21:43:48 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101316/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Replaces KUniqueApplication by a KApplication and adds a selection owner for Plasma Shells like the selection owner used by KWin (WMs in general). If plasma-desktop is already running, it is possible to restart with "plasma-desktop --replace". If plasma-desktop is running and you don't add the --replace, it will only yell (like KWin). The same could be added to the other shells like netbook, to easily restart/switch during development. I got the idea from this thread on wm-spec mailinglist: http://mail.gnome.org/archives/wm-spec-list/2011-January/msg00002.html

Current state: it works, plasma-desktop is replaced, but sometimes the WeatherEngine is causing a crash when exiting the previous one. So it is possible that the change from KUniqueApplication to KApplication is opening Pandora's Box. You decide whether it is worth to spend more time on it.


Diffs
-----

  plasma/desktop/shell/main.cpp 6f04e98 
  plasma/desktop/shell/plasmaapp.h 06ee523 
  plasma/desktop/shell/plasmaapp.cpp 58e8947 

Diff: http://git.reviewboard.kde.org/r/101316/diff


Testing
-------


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110508/93d4f35d/attachment.htm 


More information about the Plasma-devel mailing list