Review Request: Implements Plasma::TabBar::setTabHighlighted

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101264/#review3012
-----------------------------------------------------------


the look is ok enough for now, only the concern below in the implementation


plasma/private/nativetabbar.cpp
<http://git.reviewboard.kde.org/r/101264/#comment2572>

    this will have an o(n) access time, isTabHighlighted will be quite inefficient.
    should be a qvector with repacking when at item gets removed in the middle


- Marco


On May 1, 2011, 1:31 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101264/
> -----------------------------------------------------------
> 
> (Updated May 1, 2011, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Adds a setTabHighlighted and a isTabHighligted method to Plasma::TabBar.
> When a tab is highlighted its icon will be drawn with 50% opacity and the text will use Theme::HighlightColor.
> 
> So far I am not overly happy with the result.
> Marco suggested to blur the area behind the icon, though I am not sure how to do that. Another option I thought off is to either draw the button highlight effect at the area of highlighted tabs or around its icon.
> What do you think of that?
> 
> 
> Diffs
> -----
> 
>   plasma/private/nativetabbar.cpp 916deed 
>   plasma/private/nativetabbar_p.h 665d99f 
>   plasma/widgets/tabbar.h eb7a2aa 
>   plasma/widgets/tabbar.cpp 16da3b9 
> 
> Diff: http://git.reviewboard.kde.org/r/101264/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> could be nicer :/
>   http://git.reviewboard.kde.org/r/101264/s/152/
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110501/201c12f2/attachment-0001.htm