<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101264/">http://git.reviewboard.kde.org/r/101264/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the look is ok enough for now, only the concern below in the implementation</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101264/diff/1/?file=15713#file15713line87" style="color: black; font-weight: bold; text-decoration: underline;">plasma/private/nativetabbar.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span class="o"><</span><span class="kt">bool</span><span class="o">></span> <span class="n">highlightedTabs</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this will have an o(n) access time, isTabHighlighted will be quite inefficient.
should be a qvector with repacking when at item gets removed in the middle</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On May 1st, 2011, 1:31 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated May 1, 2011, 1:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a setTabHighlighted and a isTabHighligted method to Plasma::TabBar.
When a tab is highlighted its icon will be drawn with 50% opacity and the text will use Theme::HighlightColor.
So far I am not overly happy with the result.
Marco suggested to blur the area behind the icon, though I am not sure how to do that. Another option I thought off is to either draw the button highlight effect at the area of highlighted tabs or around its icon.
What do you think of that?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/private/nativetabbar.cpp <span style="color: grey">(916deed)</span></li>
<li>plasma/private/nativetabbar_p.h <span style="color: grey">(665d99f)</span></li>
<li>plasma/widgets/tabbar.h <span style="color: grey">(eb7a2aa)</span></li>
<li>plasma/widgets/tabbar.cpp <span style="color: grey">(16da3b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101264/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101264/s/152/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/01/comic_highlight_400x100.png" style="border: 1px black solid;" alt="could be nicer :/" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>