Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4040
-----------------------------------------------------------



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101550/#comment3298>

    please use KIO::del here (defined in KIO/DeleteJob)
    
    it simplifies everything and uses KIO as it should be...


- Aaron J.


On June 8, 2011, 9:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 9:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after calling the removeDirectory(before the patch) method we would have a directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -----
> 
>   projectmanager/projectmanager.cpp c00fd27 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> -------
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110620/84cc9acc/attachment.htm