Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Jun 8 23:51:03 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after calling the removeDirectory(before the patch) method we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs
-----

  projectmanager/projectmanager.cpp c00fd27 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
-------

compiles without issues and without regressions.


Thanks,

Giorgos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110608/f77fb315/attachment.htm 


More information about the Plasma-devel mailing list