Review Request: Plasmate:mainwindow::closeProject() works correctly
Aaron J. Seigo
aseigo at kde.org
Sun Jul 31 08:11:39 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102078/#review5248
-----------------------------------------------------------
Ship it!
- Aaron J.
On July 24, 2011, 8:58 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102078/
> -----------------------------------------------------------
>
> (Updated July 24, 2011, 8:58 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> hello,
>
> create a new project using plasmate and then go to File->Close Project.
> You will see the bug(look at the screenshot),this patch fixes the issue and also makes the m_docbrowser to call hide() instead of setVisible(false).
>
>
> Diffs
> -----
>
> mainwindow.cpp 3dbdefc
> startpage.h 6d45e02
>
> Diff: http://git.reviewboard.kde.org/r/102078/diff
>
>
> Testing
> -------
>
> compiles and runs fine
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/102078/s/211/
>
>
> Thanks,
>
> Giorgos
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110731/ff3d19fa/attachment.htm
More information about the Plasma-devel
mailing list