Review Request: Add missing parenthesis for classic menu item format NameDescription

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102048/#review5023
-----------------------------------------------------------


This review has been submitted with commit 13c4705bdf785389695e7e62001cace72b77467a by Burkhard Lück to branch master.

- Commit


On July 22, 2011, 12:51 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102048/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 12:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp:465 reads
> 
> i18nc("@item:inlistbox Format:", "Name Description"), MenuLauncherApplet::NameDescription);
> 
> But that does not match plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp:190
> 
> if (d->formattype == NameDescription) {
>     action->setText(QString("%1 (%2)").arg(name).arg(text));
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp eb9a0c3 
> 
> Diff: http://git.reviewboard.kde.org/r/102048/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110724/412e66da/attachment.htm