Review Request: Add missing parenthesis for classic menu item format NameDescription

Burkhard Lück lueck at hube-lueck.de
Fri Jul 22 12:51:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102048/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp:465 reads

i18nc("@item:inlistbox Format:", "Name Description"), MenuLauncherApplet::NameDescription);

But that does not match plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp:190

if (d->formattype == NameDescription) {
    action->setText(QString("%1 (%2)").arg(name).arg(text));


Diffs
-----

  plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp eb9a0c3 

Diff: http://git.reviewboard.kde.org/r/102048/diff


Testing
-------


Thanks,

Burkhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110722/b037dd92/attachment.htm 


More information about the Plasma-devel mailing list