Review Request: Be sure that Panel is resized when needed (XRandR events)

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101968/#review4810
-----------------------------------------------------------

Ship it!


a brown paper bag moment. doh! thanks for catching this. always good to have someone else look over code i've been staring at for far too long :)

- Aaron J.


On July 16, 2011, 1:34 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101968/
> -----------------------------------------------------------
> 
> (Updated July 16, 2011, 1:34 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> The bug can be reproduce:
> 1-kill plasma
> 2-Remove all screens leaving only the smaller one
> 3-Launch plasma
> 4-Add a new bigger screen
> 
> The panel will have the old size but will be placed in the right place.
> 
> The bug seems to be in the if/elseif block's that check conditions suck "The old screen was smaller, checking...". The first conditional block is to know if the config has to be saved, if the config has to be saved then none of the checks will be perform since they're in else if, so the panel won't be resized.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp e31c06d 
> 
> Diff: http://git.reviewboard.kde.org/r/101968/diff
> 
> 
> Testing
> -------
> 
> I have been messing around for 1h including vertical panels, so far so good.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110718/14a42384/attachment.htm