Review Request: Be sure that Panel is resized when needed (XRandR events)
Alex Fiestas
alex at eyeos.org
Sat Jul 16 15:34:25 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101968/
-----------------------------------------------------------
Review request for Plasma and Aaron J. Seigo.
Summary
-------
The bug can be reproduce:
1-kill plasma
2-Remove all screens leaving only the smaller one
3-Launch plasma
4-Add a new bigger screen
The panel will have the old size but will be placed in the right place.
The bug seems to be in the if/elseif block's that check conditions suck "The old screen was smaller, checking...". The first conditional block is to know if the config has to be saved, if the config has to be saved then none of the checks will be perform since they're in else if, so the panel won't be resized.
Diffs
-----
plasma/desktop/shell/panelview.cpp e31c06d
Diff: http://git.reviewboard.kde.org/r/101968/diff
Testing
-------
I have been messing around for 1h including vertical panels, so far so good.
Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110716/327c2488/attachment.htm
More information about the Plasma-devel
mailing list