Review Request: Overrides Plasma::wallpaer method addUrls() to set Image

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/
-----------------------------------------------------------

(Updated Jan. 25, 2011, 7:49 p.m.)


Review request for Plasma.


Changes
-------

Updated code changing to foreach(const KUrl& url, urls) in order to work it faster.


Summary
-------

 Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will override the method defined ( changes that have been made in http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set Image. After reviewing it I will implement both changes in Frame Applet :)


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1216449 
  trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1216449 

Diff: http://svn.reviewboard.kde.org/r/6391/diff


Testing
-------

Tested in trunk and it works perfectly.


Thanks,

Sinny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110125/e2ae0073/attachment-0001.htm