Review Request: Overrides Plasma::wallpaer method addUrls() to set Image

[Thomas Braxton]

> On Jan. 25, 2011, 4:17 p.m., Thomas Braxton wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp, line 141
> > <http://svn.reviewboard.kde.org/r/6391/diff/2/?file=44483#file44483line141>
> >
> >     shouldn't this be:
> >     foreach(const KUrl& url, urls) ?
> 
> Sinny Kumari wrote:
>     I'm kinda new to development, would be nice if you could tell how its better. Thanks :)

it doesn't use the copy constructor, it only copies a pointer so it's faster


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/#review9720
-----------------------------------------------------------


On Jan. 24, 2011, 7:49 p.m., Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6391/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2011, 7:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
>  Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will override the method defined ( changes that have been made in http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set Image. After reviewing it I will implement both changes in Frame Applet :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1216449 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1216449 
> 
> Diff: http://svn.reviewboard.kde.org/r/6391/diff
> 
> 
> Testing
> -------
> 
> Tested in trunk and it works perfectly.
> 
> 
> Thanks,
> 
> Sinny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110125/8a04335e/attachment.htm