Review Request: Make wallpaper capable of setting particular Image
Marco Martin
notmart at gmail.com
Thu Jan 20 20:42:31 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/#review9659
-----------------------------------------------------------
Ship it!
after last revision is perfect, go for it.
- Marco
On Jan. 20, 2011, 7:36 p.m., Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6375/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2011, 7:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> According to suggestion given by Aaron (refer to mailing list thread http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have done changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(const KUrl::List &urls) as public function and addUrls(const KUrl::List &urls) as protected Q_SLOTS in it so that setUrls() can be invoked from frame applet. There are more patches to come, after this one gets approved.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/wallpaper.h 1215563
> trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563
>
> Diff: http://svn.reviewboard.kde.org/r/6375/diff
>
>
> Testing
> -------
>
> Tested in trunk and everything is working fine.
>
>
> Thanks,
>
> Sinny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110120/8450f162/attachment.htm
More information about the Plasma-devel
mailing list