Review Request: remove Assert on collection id change

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100523/#review1656
-----------------------------------------------------------


I fixed kdepim/calendarsupport/calendar.cpp.

It now handles moves.

So someone just needs to copy kdepim/calendarsupport/calendar.cpp to plasma.

Please close this review.

- Sergio Luis


On Feb. 2, 2011, 8:19 a.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100523/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 8:19 a.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Summary
> -------
> 
> Actually, there is an assert when the collection id are not the same you
> are store in your cache. I work on Zanshin and I can move an Item from a
> Collection to another and i can reproduce the same behaviour with akonadiconsole.
> 
> This path remove the assert on this case and avoid a crash when we move
> the item to a different collection.
> 
> I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp 71e4fe6 
> 
> Diff: http://git.reviewboard.kde.org/r/100523/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110226/8b1a8539/attachment-0001.htm