Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

Giorgos Tsiapaliwkas terietor at gmail.com
Fri Dec 16 13:26:24 UTC 2011



> On Dec. 6, 2011, 3:51 p.m., Aaron J. Seigo wrote:
> > currently the arrow buttons don't actually move the listing forward or back, which i assume will be in another patch?

Do you mean that the plasmoid's rss list doesn't go to the next one?
Please check again the new patch since the previous was wrong.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review8761
-----------------------------------------------------------


On Dec. 16, 2011, 12:12 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 12:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -----
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> -------
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111216/d61c21a0/attachment.html>


More information about the Plasma-devel mailing list