Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review8761
-----------------------------------------------------------


currently the arrow buttons don't actually move the listing forward or back, which i assume will be in another patch?


rssnow/package/contents/ui/ListItemEntry.qml
<http://git.reviewboard.kde.org/r/103347/#comment7353>

    if the arrows were both in the same svg, this would be more efficient (they would share a the svg renderer behind the scenes)



rssnow/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/103347/#comment7352>

    this may be more easily / clearly expressed as:
    
    entryLIst.currentIndex = (entryList.currentIndex + 1) % entryList.count


- Aaron J. Seigo


On Dec. 6, 2011, 2:28 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -----
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> -------
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111206/0d86a222/attachment-0001.html>