Review Request: [Patch 2/2] Fix Sliding Popups

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103367/
-----------------------------------------------------------

(Updated Dec. 10, 2011, 7:59 a.m.)


Review request for kwin and Plasma.


Changes
-------

sanitize the offset to a reasonable value. Fixes the artifacts in Yakuake case as well as finally fixes the jump of Yakuake in the last frame of the animation if there is a top panel.

Only tested on North location as Yakuake does not want to slide from other edges.


Description
-------

Rework of sliding popups effect based on change to use "-1" as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out.

As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way.


This addresses bug 288568.
    http://bugs.kde.org/show_bug.cgi?id=288568


Diffs (updated)
-----

  kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc 

Diff: http://git.reviewboard.kde.org/r/103367/diff/diff


Testing
-------

yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111210/e4decfb2/attachment.html>