Review Request: [Patch 2/2] Fix Sliding Popups

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103367/#review8832
-----------------------------------------------------------


Not applied the other patch, but at least with yakuake (not using libplasma - property is 0,1,300,300) I get occasional artefacts under panels (ARGB or RGB+window opacity) - sometimes the first, sometimes the second last frame.

If there's another window under the panel, usually the artefacts are _above_ the panel. Otherwise below.

This is NOT related to blurring, and yes: i've even completely disabled the generic effects before ;-)

- Thomas Lübking


On Dec. 9, 2011, 5:35 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103367/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 5:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Rework of sliding popups effect based on change to use "-1" as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out.
> 
> As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way.
> 
> 
> This addresses bug 288568.
>     http://bugs.kde.org/show_bug.cgi?id=288568
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc 
> 
> Diff: http://git.reviewboard.kde.org/r/103367/diff/diff
> 
> 
> Testing
> -------
> 
> yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111209/6132721e/attachment-0001.html>