Review Request: Allow Klipper to show on current mouse position

Aaron J. Seigo aseigo at kde.org
Fri Dec 2 11:55:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103196/#review8658
-----------------------------------------------------------

Ship it!


we're in string and feature freeze for 4.8, but this can go into master soon as 4.9 development is open.


klipper/klipper.cpp
<http://git.reviewboard.kde.org/r/103196/#comment7305>

    i would suggest "at" instead of "on". perhaps: "Open klipper at current mouse position". if that is too long, drop "current" :)
    


- Aaron J. Seigo


On Nov. 23, 2011, 11:28 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103196/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 11:28 a.m.)
> 
> 
> Review request for Plasma, Esben Mose Hansen and Sune Vuorela.
> 
> 
> Description
> -------
> 
> This feature was present up until 4.3, then it got ported to the dbus menu and this regression was never fixed. This is an easy fix returning back that functionality. Fixes bug 254994.
> 
> (I'm not sure to which group I should post this, so I left it empty)
> 
> 
> This addresses bug 254994.
>     http://bugs.kde.org/show_bug.cgi?id=254994
> 
> 
> Diffs
> -----
> 
>   klipper/klipper.h e87595d 
>   klipper/klipper.cpp a588462 
> 
> Diff: http://git.reviewboard.kde.org/r/103196/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111202/54a974ab/attachment-0001.html>


More information about the Plasma-devel mailing list