Review Request: Connect to the correct signal

Aaron J. Seigo aseigo at kde.org
Wed Aug 3 07:58:57 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102173/#review5333
-----------------------------------------------------------

Ship it!


nice catch.. thanks :)

this should be applied to both 4.7 and master imho.

- Aaron J.


On Aug. 1, 2011, 11:14 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102173/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 11:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The signal parameters are wrong, plasma-desktop complains on startup
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/pager.h c482b21 
>   plasma/desktop/applets/pager/pager.cpp 588a49d 
> 
> Diff: http://git.reviewboard.kde.org/r/102173/diff
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110803/70fdddbb/attachment.html>


More information about the Plasma-devel mailing list