Review Request: Connect to the correct signal

[Albert Astals Cid]

> On Aug. 2, 2011, 2:53 p.m., Marco Martin wrote:
> > good catch
> > the slot signature change is ok, the connect syntax shouldn't matter tough
> > (ie omitting const in the connect should work and even preferred, see http://doc.qt.nokia.com/4.7/signalsandslots.html signature normalization)

Tried without adding the const to the connect statement and it still complained so i've left them in.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102173/#review5317
-----------------------------------------------------------


On Aug. 1, 2011, 11:14 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102173/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 11:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The signal parameters are wrong, plasma-desktop complains on startup
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/pager.h c482b21 
>   plasma/desktop/applets/pager/pager.cpp 588a49d 
> 
> Diff: http://git.reviewboard.kde.org/r/102173/diff
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110802/1a9ad1fe/attachment.html>