Review Request: Share FrameData between FrameSvg's

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5416/
-----------------------------------------------------------

(Updated 2010-09-23 06:47:25.265223)


Review request for Plasma.


Summary
-------

This patch implements shared FrameData between FrameSvg's. It uses a per-FrameSvg count since it is feasible that one FrameSvg could reference the same FrameData more than once. The results are reasonable: ~25% fewer pixmaps in a default plasma-desktop startup, %57 fewer pixmaps with a layout of 4 buttons, 4 line edits and a combobox in a grid layout. This results in fewer xserver roundtrips on x11 and less memory usage on all platforms. 

There is a #define near the dtor of FrameSvgPrivate that can be uncommented to see the benefits and confirm that all shared pages are indeed removed at the end. Confirming with ktracepixmap was also done.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/framesvg.h 1178444 
  /trunk/KDE/kdelibs/plasma/framesvg.cpp 1178444 
  /trunk/KDE/kdelibs/plasma/private/framesvg_p.h 1178444 

Diff: http://svn.reviewboard.kde.org/r/5416/diff


Testing
-------

Full plasma-desktop session, test plasmoid with the buttons'n'labels torture test (over 100 of each in a grid layout).


Thanks,

Aaron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100923/3192d684/attachment.htm