Review Request: Workaround plasma tooltips causing "holes" in windows

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5415/#review7725
-----------------------------------------------------------

Ship it!


this doesn't fix other ways to reproduce this bug, e.g. drop down menus. but this is probably the most common cause. (that it happens when showing a window that was previously shown only is an interesting clue for the x.org people, perhaps.) however, given that this bug has been sitting there unfixed for a couple of _years_ now with no fix in sight and that this is the most prevalent cause, coupled with it not really being a huge hack in libplasma, i'm in favour of this change in spite of the "don't work around bugs" philosophy. cheers ...

- Aaron


On 2010-09-22 23:13:41, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5415/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 23:13:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Works around an X bug that causes plasma tooltips to leave behind weird holes in windows (when compositing is off): If you trigger a tooltip which has a window under it, let the tooltip disappear, and then trigger a tooltip somewhere else, a hole appears in the window where the first tooltip used to be.
> Basically, this patch deletes the tooltip's window whenever it is hidden, and re-creates it when it is shown.
> Since it's a different window being shown the next time, the X bug doesn't happen.
> 
> I know this is a workaround for an X bug, so if you want to discard this patch and see X get fixed instead, then I can sympathize.
> However, this workaround doesn't introduce any hacks into libplasma, it just deletes a window when it isn't actually in use.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1178011 
> 
> Diff: http://svn.reviewboard.kde.org/r/5415/diff
> 
> 
> Testing
> -------
> 
> Hovered over several plasmoids, and checked that changing the tooltip while it is still visible works as well as deleting and re-creating it.
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100923/0003cbd4/attachment-0001.htm