Review Request: Workaround plasma tooltips causing "holes" in windows

[Anthony Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5415/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Works around an X bug that causes plasma tooltips to leave behind weird holes in windows (when compositing is off): If you trigger a tooltip which has a window under it, let the tooltip disappear, and then trigger a tooltip somewhere else, a hole appears in the window where the first tooltip used to be.
Basically, this patch deletes the tooltip's window whenever it is hidden, and re-creates it when it is shown.
Since it's a different window being shown the next time, the X bug doesn't happen.

I know this is a workaround for an X bug, so if you want to discard this patch and see X get fixed instead, then I can sympathize.
However, this workaround doesn't introduce any hacks into libplasma, it just deletes a window when it isn't actually in use.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1178011 

Diff: http://svn.reviewboard.kde.org/r/5415/diff


Testing
-------

Hovered over several plasmoids, and checked that changing the tooltip while it is still visible works as well as deleting and re-creating it.


Thanks,

Anthony

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100922/1a001211/attachment.htm