Review Request: Frame applet should give valid message when dropped folder doesn't have any images

[Sujith H]

> On 2010-09-15 19:34:53, Anne-Marie Mahfouf wrote:
> > - You forgot to remove the class SlideShow; and #include "slideshow.h" from the Picture class
> > - The message is not so good "Folder that is dropped is empty. Please drop a folder with image(s)". Maybe "Dropped folder is empty. Please drop a folder with image(s)" An English speaker can improve this.
> > - There should not be the 2 arrows on the picture (the next and previous ones that only make sense on a slideshow). If you then drop a picture in it the 2 arrows stay. This seems to be a bug that existed before the patch though (the arrows stay after a slideshow)

Anne-Marie, thanks for pointing out my mistake. I will remove class SlideShow; and #include "slideshow.h" from Picture Class. The suggestion regarding message is noted down. You are correct may be an English speaker can improve this. Will it be ok if I spent some more time for the 2 arrows problem. May I take it as my next task?


- Sujith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/#review7623
-----------------------------------------------------------


On 2010-09-16 03:54:44, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5362/
> -----------------------------------------------------------
> 
> (Updated 2010-09-16 03:54:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 
> 
> Diff: http://svn.reviewboard.kde.org/r/5362/diff
> 
> 
> Testing
> -------
> 
> This has been tested. 
> 
> 
> Thanks,
> 
> Sujith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100916/d6ea4e1c/attachment-0001.htm