Review Request: Frame applet should give valid message when dropped folder doesn't have any images

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/#review7624
-----------------------------------------------------------



trunk/KDE/kdeplasma-addons/applets/frame/picture.h
<http://svn.reviewboard.kde.org/r/5362/#comment7775>

    trailing whitespace, please remove



trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp
<http://svn.reviewboard.kde.org/r/5362/#comment7778>

    "Info" doesn't help translators a lot, how about "overlay text when hovered" or something like that? Imagine the translator reading this, if he knows where it'll show up it's much easier for him/her to find the best possible translation.



trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp
<http://svn.reviewboard.kde.org/r/5362/#comment7777>

    should probably be a bool



trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp
<http://svn.reviewboard.kde.org/r/5362/#comment7776>

    Don't use a magic string here, a bool looks more in place?


- Sebastian


On 2010-09-15 18:45:47, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5362/
> -----------------------------------------------------------
> 
> (Updated 2010-09-15 18:45:47)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 
> 
> Diff: http://svn.reviewboard.kde.org/r/5362/diff
> 
> 
> Testing
> -------
> 
> This has been tested. 
> 
> 
> Thanks,
> 
> Sujith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100915/955bc0c6/attachment.htm