Review Request: Add suspend-signal to powerdevil and make plasma time dataengine detecting clock skrews

[Björn Ruberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5320/
-----------------------------------------------------------

Review request for Plasma and Solid.


Summary
-------

NOTE: This a little bit ugly as I have to workaround the missing "going to suspend"-signal in the linux userland

This patch adds a signal to powerdevil that is emitted when a suspend/hibernate/standby is requested there. The signal is caught by the time engine what starts to look for an unexpected change in system time for two minutes by polling. If a clock skrew is detected, all sources are updated immediatly.

This fixes the bug that the plasma clocks are showing old time after suspending your machine up until 59 seconds (whenever the normal update is scheduled). This is not exactly a patch for bug 181380. But the clock skrew detection code can be used quite similar for detecting normal time changes. I'll look into that as soon this is accepted.

Please tell me whether I can commit this to 4.5 trunk as it is a bugfix for a nasty glitch.


This addresses bug 181380.
    https://bugs.kde.org/show_bug.cgi?id=181380


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/time/timeengine.h 1166313 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/time/timeengine.cpp 1166313 
  /trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.h 1166313 
  /trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.cpp 1166313 
  /trunk/KDE/kdebase/workspace/powerdevil/daemon/org.kde.PowerDevil.xml 1166313 

Diff: http://svn.reviewboard.kde.org/r/5320/diff


Testing
-------

Suspended machine, waited three minutes, woke up again - and noticed that all clocks on screen showed the correct time almost immediatly :)


Thanks,

Björn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100913/0ea5ae75/attachment.htm