Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5225/#review7460
-----------------------------------------------------------


The ifdefs doesn't make sense. It looks to me like the effect requires OpenGL. So make it an OpenGL only effect and add the static supported method which checks for OpenGL. A reference effect is e.g. Cube, CoverSwitch or FlipSwitch.


tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h
<http://svn.reviewboard.kde.org/r/5225/#comment7657>

    You could forward declare GLTexture and remove the include for kwinglutils.h.
    
    Also you do not need the ifdef if you forward declare it.



tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h
<http://svn.reviewboard.kde.org/r/5225/#comment7658>

    I would not use a pointer for a QRect. Just create a new one in the implementation and use the copy operator.



tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp
<http://svn.reviewboard.kde.org/r/5225/#comment7659>

    No need to includ gl.h if you include kwinglutils.h.


- Martin


On 2010-09-07 17:43:25, Christoph Fritz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5225/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 17:43:25)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Summary
> -------
> 
> Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes corners of the desktop rounded.
> Older Macs and Monitors had this feature too.
> 
> 
> Diffs
> -----
> 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170001 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5225/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> roundedcorners_without_frame
>   http://svn.reviewboard.kde.org/r/5225/s/498/
> with_simulated_border
>   http://svn.reviewboard.kde.org/r/5225/s/499/
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100907/43a74c9e/attachment-0001.htm