Review Request: More improvements to the Fifteen puzzle

[Anthony Bryant]

> On 2010-10-26 08:12:13, Marco Martin wrote:
> > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp, line 36
> > <http://svn.reviewboard.kde.org/r/5617/diff/1/?file=39260#file39260line36>
> >
> >     shouldn't be 0

The reason I set it to 0 here is that I have to call setSize(size) later, and that doesn't do anything if size == m_size.
It should be safe though, because nothing uses m_size between here and the call to setSize(size). I've updated the comment to make this more clear.


> On 2010-10-26 08:12:13, Marco Martin wrote:
> > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp, line 60
> > <http://svn.reviewboard.kde.org/r/5617/diff/1/?file=39260#file39260line60>
> >
> >     m_size = qMax(size, 1)
> >     you added several foo % m_size, ensuring isn't 0 is important :)

Good point, thanks. I've just fixed in my local copy.
I'll commit in a few minutes.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5617/#review8359
-----------------------------------------------------------


On 2010-10-13 13:40:36, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5617/
> -----------------------------------------------------------
> 
> (Updated 2010-10-13 13:40:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Lots more improvements to the fifteen puzzle:
> * Improved shuffle algorithm
> * Resize fonts when the board size is changed
> * Better checking for whether the board is solved
> * Stop the pieces flickering when they are moved
> * Changed the way board positions are stored
> * Animate in the blank piece when the puzzle is solved
> * Add a status bar underneath the puzzle, which shows a shuffle button and the time elapsed
> 
> 
> This addresses bug 156648.
>     https://bugs.kde.org/show_bug.cgi?id=156648
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1185297 
> 
> Diff: http://svn.reviewboard.kde.org/r/5617/diff
> 
> 
> Testing
> -------
> 
> Solved the puzzle a few times, changed some settings, resized the applet.
> 
> 
> Screenshots
> -----------
> 
> new puzzle layout
>   http://svn.reviewboard.kde.org/r/5617/s/535/
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101026/e16542f6/attachment.htm