Review Request: More improvements to the Fifteen puzzle

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5617/#review8359
-----------------------------------------------------------

Ship it!


apart the two comments below it's ok


/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp
<http://svn.reviewboard.kde.org/r/5617/#comment8644>

    shouldn't be 0



/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp
<http://svn.reviewboard.kde.org/r/5617/#comment8645>

    m_size = qMax(size, 1)
    you added several foo % m_size, ensuring isn't 0 is important :)


- Marco


On 2010-10-13 13:40:36, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5617/
> -----------------------------------------------------------
> 
> (Updated 2010-10-13 13:40:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Lots more improvements to the fifteen puzzle:
> * Improved shuffle algorithm
> * Resize fonts when the board size is changed
> * Better checking for whether the board is solved
> * Stop the pieces flickering when they are moved
> * Changed the way board positions are stored
> * Animate in the blank piece when the puzzle is solved
> * Add a status bar underneath the puzzle, which shows a shuffle button and the time elapsed
> 
> 
> This addresses bug 156648.
>     https://bugs.kde.org/show_bug.cgi?id=156648
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1185297 
>   /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1185297 
> 
> Diff: http://svn.reviewboard.kde.org/r/5617/diff
> 
> 
> Testing
> -------
> 
> Solved the puzzle a few times, changed some settings, resized the applet.
> 
> 
> Screenshots
> -----------
> 
> new puzzle layout
>   http://svn.reviewboard.kde.org/r/5617/s/535/
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101026/cb638c36/attachment-0001.htm