Review Request: Kickoff application uninstaller

[Aaron Seigo]

> On 2010-11-25 23:51:56, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp, lines 104-117
> > <http://svn.reviewboard.kde.org/r/5974/diff/1/?file=41716#file41716line104>
> >
> >     this would be better with a QDBusServiceWatcher (faster, also detect changes at runtime, not have to expose DBus internals directly in the code)

after further discussion on irc with dantti, it turns out that org.freedesktop.PackageKit may not be running and only activatable, so it needs to be checked for being available for activation. so this approach, while ugly (typical for direct dbus calls like this), is probably the best/only approach at hand.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8979
-----------------------------------------------------------


On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> -----------------------------------------------------------
> 
> (Updated 2010-11-25 23:48:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if it's not available the
> right click option to "Uninstall" applications will not be displayed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 1200785 
> 
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Kickoff Uninstaller
>   http://svn.reviewboard.kde.org/r/5974/s/563/
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101126/404a7a9b/attachment.htm