Review Request: Kickoff application uninstaller

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8979
-----------------------------------------------------------


looks good (for 4.7), with the exception of using QDBusServiceWatcher.


/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
<http://svn.reviewboard.kde.org/r/5974/#comment9727>

    this would be better with a QDBusServiceWatcher (faster, also detect changes at runtime, not have to expose DBus internals directly in the code)


- Aaron


On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> -----------------------------------------------------------
> 
> (Updated 2010-11-25 23:48:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if it's not available the
> right click option to "Uninstall" applications will not be displayed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 1200785 
> 
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Kickoff Uninstaller
>   http://svn.reviewboard.kde.org/r/5974/s/563/
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101125/873c87b3/attachment-0001.htm