Review Request: Save the notification position in relation to the screen border

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5914/#review8867
-----------------------------------------------------------

Ship it!


yes, saving the screen number was a bit unfortunate, as we talked about it some days ago, this should go in

- Marco


On 2010-11-20 19:34:11, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5914/
> -----------------------------------------------------------
> 
> (Updated 2010-11-20 19:34:11)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Currently we're saving the notifications using absolute positions, because of this the notification is misplaced if the resolution changes, or the desktop is extended with another monitor.
> 
> This patch changes the way the position is saved, by doing it measuring the space between the notification and the screen borders. For example if we place the notification 10px from bottom and 10px from right, no matters how the screen configuration changes, it will be always placed 10px bottom 10px right.
> 
> The only thing left to handle properly is "center" the notification just like KRunner does, but that will be another patch.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h 1198889 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.cpp 1198889 
> 
> Diff: http://svn.reviewboard.kde.org/r/5914/diff
> 
> 
> Testing
> -------
> 
> I tried to misplace the notification by changing the resolution, added/removing displays and so far everything has worked well.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101120/d54f74c1/attachment.htm