<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5914/">http://svn.reviewboard.kde.org/r/5914/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, saving the screen number was a bit unfortunate, as we talked about it some days ago, this should go in</pre>
<br />
<p>- Marco</p>
<br />
<p>On November 20th, 2010, 7:34 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated 2010-11-20 19:34:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently we're saving the notifications using absolute positions, because of this the notification is misplaced if the resolution changes, or the desktop is extended with another monitor.
This patch changes the way the position is saved, by doing it measuring the space between the notification and the screen borders. For example if we place the notification 10px from bottom and 10px from right, no matters how the screen configuration changes, it will be always placed 10px bottom 10px right.
The only thing left to handle properly is "center" the notification just like KRunner does, but that will be another patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to misplace the notification by changing the resolution, added/removing displays and so far everything has worked well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h <span style="color: grey">(1198889)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.cpp <span style="color: grey">(1198889)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5914/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>