Review Request: Fixes the "run as different user"-option in the "Shell" runner

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5887/#review8783
-----------------------------------------------------------

Ship it!


- Aaron


On 2010-11-17 15:22:17, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5887/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 15:22:17)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> The "run as different user" command works again now by using KDESu::SuProcess instead of KDESu::KDEsuClient. The later's behavior was hard to understand, like which pw to enter and how long they will be kept, now the pw will be only kept for this command and has to be always reentered.
> 
> Further improvements:
> *The input-fields look different when deactivated.
> *Also automatically changes the focus to the username-input-field if "use as a different user" is enabled.
> 
> BUG:205229
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/shell/shell_config.cpp 1198064 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/shell/shellrunner.cpp 1198064 
> 
> Diff: http://svn.reviewboard.kde.org/r/5887/diff
> 
> 
> Testing
> -------
> 
> Runnin "konsole" as different user.
> Tested "passwd -S" to run in a terminal and as different user, the correct information was printed out.
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101117/74833ce3/attachment.htm