Review Request: Fixes the "run as different user"-option in the "Shell" runner

Matthias Fuchs mat69 at gmx.net
Wed Nov 17 16:22:17 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5887/
-----------------------------------------------------------

(Updated 2010-11-17 15:22:17.556155)


Review request for Plasma and Aaron Seigo.


Changes
-------

small description change


Summary (updated)
-------

The "run as different user" command works again now by using KDESu::SuProcess instead of KDESu::KDEsuClient. The later's behavior was hard to understand, like which pw to enter and how long they will be kept, now the pw will be only kept for this command and has to be always reentered.

Further improvements:
*The input-fields look different when deactivated.
*Also automatically changes the focus to the username-input-field if "use as a different user" is enabled.

BUG:205229


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/runners/shell/shell_config.cpp 1198064 
  /trunk/KDE/kdebase/workspace/plasma/generic/runners/shell/shellrunner.cpp 1198064 

Diff: http://svn.reviewboard.kde.org/r/5887/diff


Testing
-------

Runnin "konsole" as different user.
Tested "passwd -S" to run in a terminal and as different user, the correct information was printed out.


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101117/de5b550e/attachment.htm 


More information about the Plasma-devel mailing list