Review Request: [4.7] Makes it possible to specify the language spell check runner should use, e.g. "spell_de $TERM".

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5849/#review8744
-----------------------------------------------------------

Ship it!


looks good; the natural language name for the language was just an idea, i didn't expect it to actually be so easy to implement basic support for it. nicely done! :)

i'd like to see this in 4.6, tbh. yes, soft feature freeze and all but i don't see the point of waiting until middle of next year for something like this which is small and an obvious benefit by improving an existing feature.

- Aaron


On 2010-11-15 16:46:01, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5849/
> -----------------------------------------------------------
> 
> (Updated 2010-11-15 16:46:01)
> 
> 
> Review request for Plasma and Ryan Bitanga.
> 
> 
> Summary
> -------
> 
> Makes it possible to specify the language spell checker should use, e.g. "spell $LANG_CODE $TERM" or "spell $LANG_NAME $TERM".
> 
> $LANG_CODE could be "de", "de_AT" etc. and $LANG_NAME is the localized language name like "german" on a english locale or "allemand" on a french one.
> Also language names like "american english" are possible. $LANG_NAME is case insensitive.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.h 1197278 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp 1197278 
> 
> Diff: http://svn.reviewboard.kde.org/r/5849/diff
> 
> 
> Testing
> -------
> 
> Tested with both English and German locale set.
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101115/eff3060b/attachment.htm