<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5849/">http://svn.reviewboard.kde.org/r/5849/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good; the natural language name for the language was just an idea, i didn't expect it to actually be so easy to implement basic support for it. nicely done! :)
i'd like to see this in 4.6, tbh. yes, soft feature freeze and all but i don't see the point of waiting until middle of next year for something like this which is small and an obvious benefit by improving an existing feature.</pre>
<br />
<p>- Aaron</p>
<br />
<p>On November 15th, 2010, 4:46 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Ryan Bitanga.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-15 16:46:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes it possible to specify the language spell checker should use, e.g. "spell $LANG_CODE $TERM" or "spell $LANG_NAME $TERM".
$LANG_CODE could be "de", "de_AT" etc. and $LANG_NAME is the localized language name like "german" on a english locale or "allemand" on a french one.
Also language names like "american english" are possible. $LANG_NAME is case insensitive.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with both English and German locale set.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.h <span style="color: grey">(1197278)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp <span style="color: grey">(1197278)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>