Review Request: Enables KRunner resizing when it is floating and improves resizing started on the left

Matthias Fuchs mat69 at gmx.net
Sun Nov 14 12:30:18 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5846/
-----------------------------------------------------------

Review request for Plasma and Aaron Seigo.


Summary
-------

KRunner's width can be resized when it is floating.
Also resizing on the left size is improved --> the cursor stays at the left edge.
BUG:256334

What is still not ideal is when you resize the runner on the left side and it reaches the right screenboarder, then it looks a little choppy but works.

There is also still a problem existing -- unrelated to this patch: When it is on top and in the middle and you resize it to the maximum, hide it, try to move it ... it sometimes happens that you can't resize it anymore.


Note: This review also includes http://reviewboard.kde.org/r/5844/ as I was not able to do it without via post-review.


Diffs
-----

  /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1196906 
  /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1196906 

Diff: http://svn.reviewboard.kde.org/r/5846/diff


Testing
-------

Tried different cases both in floating and non-floating:
resizing it both on the left and right when it is centered, positioned on the left or on the right


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101114/9cf893ae/attachment.htm 


More information about the Plasma-devel mailing list