Review Request: Plasma doesn't follow Kiosk restrictions

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5823/#review8680
-----------------------------------------------------------


the patch looks incorrect; there are also so many different places in which kiosk settings can be put, that this comment: "Plasma doesn't seem to follow Kiosk restrictions at all" is vague. which restrictions were tested and didn't work? [$i] at the global scope in plasma-desktop-appletsrc? on a containment group? etc... 

- Aaron


On 2010-11-10 16:39:31, Lubos Lunak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5823/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 16:39:31)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Probably as a result of r800724, Plasma doesn't seem to follow Kiosk restrictions at all (just grep the sources for where SystemImmutable is assigned to something - it isn't). This patch may possibly be a suitable fix.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/applet.cpp 1182745 
> 
> Diff: http://svn.reviewboard.kde.org/r/5823/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lubos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101112/0f3890c3/attachment.htm