<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5823/">http://svn.reviewboard.kde.org/r/5823/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the patch looks incorrect; there are also so many different places in which kiosk settings can be put, that this comment: "Plasma doesn't seem to follow Kiosk restrictions at all" is vague. which restrictions were tested and didn't work? [$i] at the global scope in plasma-desktop-appletsrc? on a containment group? etc... </pre>
<br />
<p>- Aaron</p>
<br />
<p>On November 10th, 2010, 4:39 p.m., Lubos Lunak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Lubos Lunak.</div>
<p style="color: grey;"><i>Updated 2010-11-10 16:39:31</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably as a result of r800724, Plasma doesn't seem to follow Kiosk restrictions at all (just grep the sources for where SystemImmutable is assigned to something - it isn't). This patch may possibly be a suitable fix.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: grey">(1182745)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5823/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>