Review Request: Plasma doesn't follow Kiosk restrictions

[Chani Armitage]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5823/#review8624
-----------------------------------------------------------


no, I don't think this is correct.

check out line 880:
ImmutabilityType Applet::immutability() const
that function doesn't return d->immutability, but the strongest of that and various other checks. and it suggests that Corona::immutability() should be responsible for checking kiosk things.

I'm not sure what checkImmutability is supposed to be doing, but setting d->immutability isn't it ;)

...also note that, once you set SystemImmutable, you can't unset it. at least that's how the code read to me. so test that kiosk can both lock *and* unlock things ;)

- Chani


On 2010-11-10 16:39:31, Lubos Lunak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5823/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 16:39:31)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Probably as a result of r800724, Plasma doesn't seem to follow Kiosk restrictions at all (just grep the sources for where SystemImmutable is assigned to something - it isn't). This patch may possibly be a suitable fix.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/applet.cpp 1182745 
> 
> Diff: http://svn.reviewboard.kde.org/r/5823/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lubos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101110/aa199fe6/attachment.htm